From: Julien Grall Date: Thu, 29 Jul 2021 11:06:02 +0000 (+0100) Subject: tools/xenstored: Propagate correctly the error message from lu_start() X-Git-Tag: archive/raspbian/4.16.0+51-g0941d6cb-1+rpi1~2^2~42^2~304 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/success/%22http:/www.example.com/cgi/success?a=commitdiff_plain;h=604551fb763c4c70123f642a9b2866890790e2b2;p=xen.git tools/xenstored: Propagate correctly the error message from lu_start() lu_start() will only set errno when it returns NULL. For all the other cases, the value is unknown. This means that when lu_start() returns an error message, it may not be propagated to the client. The check that errno is a non-zero value is now dropped and instead the value is returned when no error message is provided. This relies on errno to always be set when ret == NULL. Fixes: af216a99fb ("tools/xenstore: add the basic framework for doing the live update") Signed-off-by: Julien Grall Reviewed-by: Juergen Gross --- diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_control.c index ff9863c17f..6b68b79faa 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -795,10 +795,8 @@ static int do_control_lu(void *ctx, struct connection *conn, return EINVAL; } ret = lu_start(ctx, conn, force, to); - if (errno) - return errno; if (!ret) - return 0; + return errno; } else { errno = 0; ret = lu_arch(ctx, conn, vec, num);